feat(ebe, mbe): added recovery to MPCv2 #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextse-bg
force-pushed
the
WP-5168
branch
4 times, most recently
from
c107cb0 to
25c9a75
Compare
mohammadalfaiyazbitgo
requested changes
Jul 16, 2025
alextse-bg
force-pushed
the
WP-5168
branch
5 times, most recently
from
fa2d675 to
35c71ca
Compare
pranavjain97
requested changes
Jul 18, 2025
| const coin = bitgo.coin(req.decoded.coin); | ||
|
|
||
| // setup clients and retreive the keys | ||
| // TODO: this needs to be segerated if the EBE instance cannot retrieve both keys |
Contributor
There was a problem hiding this comment.
create a ticket and add here
mohammadalfaiyazbitgo
requested changes
Jul 18, 2025
mohammadalfaiyazbitgo
requested changes
Jul 24, 2025
alextse-bg
force-pushed
the
WP-5168
branch
3 times, most recently
from
793c7ba to
a23341c
Compare
mohammadalfaiyazbitgo
requested changes
Jul 24, 2025
alextse-bg
force-pushed
the
WP-5168
branch
6 times, most recently
from
fb598d9 to
4116bd6
Compare
alextse-bg
force-pushed
the
WP-5168
branch
2 times, most recently
from
b3dc3d5 to
902eb4b
Compare
mohammadalfaiyazbitgo
requested changes
Jul 25, 2025
| const { BigNumber } = await import('bignumber.js'); | ||
|
|
||
| const MPC = new Ecdsa(); | ||
| const publicKey = MPC.deriveUnhardened(params.commonKeychain, 'm/0').slice(0, 66); |
Contributor
There was a problem hiding this comment.
nit: seed should be a parameter like m/{seed}
Contributor
There was a problem hiding this comment.
with default being m/0
|
|
||
| const chainId = await baseCoin['getChainId'](); | ||
|
|
||
| const [accountNumber, sequenceNo] = await baseCoin['getAccountDetails'](senderAddress); |
Contributor
There was a problem hiding this comment.
why do you need to call the function like this?
|
|
||
| // post processing of the response | ||
| if (isEthLikeCoin(baseCoin)) { | ||
| const { AbstractEthLikeNewCoins } = await import('@bitgo-beta/sdk-coin-eth'); |
Contributor
There was a problem hiding this comment.
shouldn't need to do this anymore. just cast as AbstractEthLikeNewCoins on baseCoin.
Contributor
There was a problem hiding this comment.
import from @bitgo-beta/abstract-eth
alextse-bg
force-pushed
the
WP-5168
branch
2 times, most recently
from
e9861f3 to
d6e2002
Compare
alextse-bg
force-pushed
the
WP-5168
branch
3 times, most recently
from
1a4d80e to
acef0ae
Compare
pranavjain97
previously approved these changes
Jul 25, 2025
alextse-bg
force-pushed
the
WP-5168
branch
2 times, most recently
from
9415d58 to
2545b25
Compare
mohammadalfaiyazbitgo
requested changes
Jul 28, 2025
Contributor
mohammadalfaiyazbitgo
left a comment
mohammadalfaiyazbitgo
left a comment
There was a problem hiding this comment.
see unresolved comments.
alextse-bg
force-pushed
the
WP-5168
branch
3 times, most recently
from
aaae8a2 to
787c431
Compare
mohammadalfaiyazbitgo
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bitgoinc.atlassian.net/jira/software/c/projects/WP/boards/340?assignee=712020%3A33a7aa1d-2687-4db8-a101-ad18996acf6f&selectedIssue=WP-5168